friendlymatthew commented on PR #8891: URL: https://github.com/apache/arrow-rs/pull/8891#issuecomment-3611277009
> > `UnionFields::from_fields` is a convenience constructor that auto-assigns sequential type ids starting from 0. (Will panic if it exceeds 128 elements) > > Perhaps we should error instead of panicking for >128 elements? Hi, that makes sense to me. I do really like `from_fields` being infallible for the cases when I hard code my UnionFields. What if we include a fallible version, something like `UnionFields::try_from_fields` and inform users on which method to use -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
