Vishwanatha-HD commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2589738148
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, FlatBuffer serialization can produce slightly
different
+ // output across different platforms and toolchains.
Review Comment:
@pitrou.. Yes.. of-course.. I have undone my changes.. and then did the
below changes..
1) Wrapped the testcase logic inside the for loop.. So, that it runs on both
the LE and BE machines..
for (const auto endianness : {Endianness::Little, Endianness::Big}) {
auto schema = ::arrow::schema({f0}, endianness, metadata);
}
(please note that the other lines remains same as is in the main branch)..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
