wgtmac commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2593090285
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2003,7 +2018,7 @@ Status
TypedColumnWriterImpl<ParquetType>::WriteArrowDictionary(
AddIfNotNull(rep_levels, offset));
std::shared_ptr<Array> writeable_indices =
indices->Slice(value_offset, batch_num_spaced_values);
- if (page_statistics_) {
+ if (page_statistics_ || bloom_filter_writer_->bloom_filter_enabled()) {
Review Comment:
Because `update_stats` is reused for preparing the dictionary values.
Perhaps we should rename `update_stats` to `update_index` if we regard all of
them as index?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
