wecharyu commented on code in PR #48468:
URL: https://github.com/apache/arrow/pull/48468#discussion_r2613522654
##########
cpp/src/parquet/arrow/writer.cc:
##########
@@ -480,17 +476,28 @@ class FileWriterImpl : public FileWriter {
return Status::OK();
};
+ // Max number of rows allowed in a row group.
+ const int64_t max_row_group_length =
this->properties().max_row_group_length();
Review Comment:
Not sure whether we should validate that such config value is positive.
If it's set to 0, the processor would never exit the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]