mapleFU commented on code in PR #8989:
URL: https://github.com/apache/arrow-rs/pull/8989#discussion_r2617197871
##########
arrow-array/src/builder/fixed_size_binary_builder.rs:
##########
@@ -270,4 +288,40 @@ mod tests {
fn test_fixed_size_binary_builder_invalid_value_length() {
let _ = FixedSizeBinaryBuilder::with_capacity(15, -1);
}
+
+ #[test]
+ fn test_fixed_size_binary_builder_append_array() {
+ let mut other_builder = FixedSizeBinaryBuilder::with_capacity(3, 5);
+ other_builder.append_value(b"hello").unwrap();
+ other_builder.append_null();
+ other_builder.append_value(b"arrow").unwrap();
+ let other_array = other_builder.finish();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(3, 5);
+ builder.append_array(&other_array).unwrap();
+ let array = builder.finish();
+
+ assert_eq!(array.value_length(), other_array.value_length());
Review Comment:
I'm thinking about that would it better for append multiple times to make
sure the impl not breaks previous data?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
