alamb commented on code in PR #9001: URL: https://github.com/apache/arrow-rs/pull/9001#discussion_r2620483330
########## arrow-csv/src/writer.rs: ########## @@ -75,14 +74,13 @@ //! - `DataType::LargeUtf8` //! - `DataType::Utf8View` //! -//! ## Example with whitespace handling +//! ## Example: Use [`WriterBuilder`] to control whitespace handling Review Comment: This already has the contents of arrow-csv/examples/whitespace_handling.rs, so let's not duplicate it again ########## arrow-csv/src/reader/mod.rs: ########## @@ -42,6 +42,46 @@ //! let batch = csv.next().unwrap().unwrap(); //! ``` //! +//! # Example: Numeric calculations on CSV Review Comment: Contents of arrow-csv/examples/csv_calculation.rs ########## arrow-csv/src/reader/mod.rs: ########## @@ -441,13 +481,18 @@ pub fn infer_schema_from_files( type Bounds = Option<(usize, usize)>; /// CSV file reader using [`std::io::BufReader`] +/// Review Comment: I added a few more doc links to make it easier to navigate between the different classes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
