kou commented on code in PR #48313:
URL: https://github.com/apache/arrow/pull/48313#discussion_r2621438433
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -186,6 +186,7 @@ if(WIN32)
#
# ARROW-2986: Without /EHsc we get C4530 warning
set(CXX_COMMON_FLAGS "/W3 /EHsc")
+ string(APPEND CMAKE_CXX_FLAGS " /EHsc")
Review Comment:
OK. Could you try this?
```diff
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 7286616c4f..c9f026f926 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -520,8 +520,6 @@ endif()
set(PARQUET_PC_REQUIRES "")
set(PARQUET_PC_REQUIRES_PRIVATE "")
-include(ThirdpartyToolchain)
-
# Add common flags
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_COMMON_FLAGS}")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}")
@@ -536,6 +534,8 @@ string(REPLACE "-std=c++17" "" CMAKE_C_FLAGS
${CMAKE_C_FLAGS})
# Add C++-only flags, like -std=c++17
set(CMAKE_CXX_FLAGS "${CXX_ONLY_FLAGS} ${CMAKE_CXX_FLAGS}")
+include(ThirdpartyToolchain)
+
# ASAN / TSAN / UBSAN
if(ARROW_FUZZING)
set(ARROW_USE_COVERAGE ON)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
