raulcd commented on code in PR #48556: URL: https://github.com/apache/arrow/pull/48556#discussion_r2623748949
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -3120,10 +3121,13 @@ function(build_grpc) # Add warning suppression flags for gRPC build. if(NOT MSVC) - string(APPEND CMAKE_C_FLAGS - " -Wno-attributes -Wno-format-security -Wno-unknown-warning-option") - string(APPEND CMAKE_CXX_FLAGS - " -Wno-attributes -Wno-format-security -Wno-unknown-warning-option") + string(APPEND CMAKE_C_FLAGS " -Wno-attributes -Wno-format-security") + string(APPEND CMAKE_CXX_FLAGS " -Wno-attributes -Wno-format-security") + endif() + if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID STREQUAL + "Clang") + string(APPEND CMAKE_C_FLAGS " -Wno-unknown-warning-option") + string(APPEND CMAKE_CXX_FLAGS " -Wno-unknown-warning-option") Review Comment: This isn't strictly necessary for this PR but I found that it was raising a warning: ``` At global scope: cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
