amoeba commented on code in PR #3814:
URL: https://github.com/apache/arrow-adbc/pull/3814#discussion_r2623940447


##########
c/driver_manager/CMakeLists.txt:
##########


Review Comment:
   Any reason not to do something like this just for consistency?
   
   ```suggestion
      add_dependencies(adbc-driver-manager-test adbc_driver_sqlite_shared)
      target_compile_definitions(adbc-driver-manager-test
   PRIVATE 
ADBC_DRIVER_MANAGER_TEST_LIB="$<TARGET_FILE:adbc_driver_sqlite_shared>"
   )
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to