carlsverre opened a new pull request, #580:
URL: https://github.com/apache/arrow-rs-object-store/pull/580
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #579
# Rationale for this change
Consistently expose HttpError in the source chain for all http errors.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
The issue is caused by `#[error(transparent)]`, which forwards the source
method to the underlying error's source impl. The intention is that
`transparent` results in the underlying error appearing to be embedded
transparently within the embedding error. This means a user can't retrieve the
`HttpError` via reflection.
I also added a test to verify that you can retrieve the HttpError in the
source chain.
# Are there any user-facing changes?
`source` will start returning HttpError before `reqwest::Error` when
executed recursively. Hopefully, users recursively search for errors. This will
break users who expect `reqwest::Error` to be at a fixed number of steps below
the root error type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
