paleolimbot commented on code in PR #48541:
URL: https://github.com/apache/arrow/pull/48541#discussion_r2627457549
##########
format/Message.fbs:
##########
@@ -55,14 +55,15 @@ enum CompressionType:byte {
/// Provided for forward compatibility in case we need to support different
/// strategies for compressing the IPC message body (like whole-body
/// compression rather than buffer-level) in the future
-enum BodyCompressionMethod:byte {
+enum BodyCompressionMethod: byte {
/// Each constituent buffer is first compressed with the indicated
/// compressor, and then written with the uncompressed length in the first 8
/// bytes as a 64-bit little-endian signed integer followed by the compressed
/// buffer bytes (and then padding as required by the protocol). The
/// uncompressed length may be set to -1 to indicate that the data that
/// follows is not compressed, which can be useful for cases where
/// compression does not yield appreciable savings.
+ /// Also, empty buffers can optionally omit the 8-byte length header.
Review Comment:
No strong feelings about this suggestion, but maybe what we mean is:
```suggestion
/// Also, empty buffers may optionally omit the 8-byte length header such
that
/// an empty compressed buffer may be written as `00 00 00 00 00 00 00 00`
instead
/// of `ff ff ff ff ff ff ff ff 00 00 00 00 00 00 00 00`. The latter is
preferred for
/// consistency with the text of this specification before this
clarification was added
/// to account for the long-standing behaviour of some implementations.
```
(feel free to correct if this isn't what we mean 🙂 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
