scovich commented on PR #8998: URL: https://github.com/apache/arrow-rs/pull/8998#issuecomment-3667615068
> > > > TBH, I don't think I understand it well enough to have a strong opinion. In particular, I didn't follow how the proposed extension stuff would help solve what problem this PR has? > > > > > > > > > The extension would avoid adding a dependency in arrow-json on parquet-variant > > > Extensions would also allow for other use cases as well, so I was thinking spending the time to work out a proper API might make sense (we have a use case in repo -- variant, and we have external use cases as well) > > > > > > Gotcha, thanks. What might the extension look like? More than making `ArrayDecoder` public so that the `VariantArrayDecoder` can move to a better place? > > I was envisioning very minor tweaks to #7442 The use case seems compelling. My past bad experiences with Java and `FactoryProviderRegistryFactory` type classes makes it hard to like factory/registry based approaches at first glance... but I have no idea what a better approach might even look like so I should probably just bite my tongue 😛. Especially given that the companion PR (for JSON encoding) already merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
