pitrou commented on code in PR #47141: URL: https://github.com/apache/arrow/pull/47141#discussion_r2630069155
########## python/setup.py: ########## @@ -25,6 +25,7 @@ import shlex import sys import warnings +import shutil Review Comment: Nit: leave imports in alphabetical order ########## python/.gitignore: ########## @@ -45,3 +45,7 @@ pyarrow/_table_api.h manylinux1/arrow nm_arrow.log visible_symbols.log + +# don't repeat the text files Review Comment: Can we make the comment more explanatory? "Don't repeat" doesn't explain why they would be repeated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
