pitrou commented on issue #48589: URL: https://github.com/apache/arrow/issues/48589#issuecomment-3678627992
> [@pitrou](https://github.com/pitrou) I have a couple of questions: > > 1. From what I’ve seen, `arrow::util::SafeCopy` seems to be the only place that could be replaced with `std::bit_cast`. Are there any other places I should consider? There may be other places in the source code where we use the `memcpy` trick directly, it would be worth finding them. > 2. In your opinion, would it be preferable to replace `arrow::util::SafeCopy` with `std::bit_cast`, or to keep the API and just update the implementation to use `std::bit_cast` internally? It depends if `std::bit_cast` is as ergonomic as the current APIs. The APIs do a little bit more than just bit-cast, since they dereference pointers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
