vladborovtsov commented on PR #47663: URL: https://github.com/apache/arrow/pull/47663#issuecomment-3678868357
There is not too much to add into `column_builder_test.cc`: the introduced `default_column_type` affects only reader. And reader using typed columns when default specified, for details see [cpp/src/arrow/csv/reader.cc](https://github.com/apache/arrow/pull/47663/files#diff-dd33f8fee95a758371b67d6294ff9bfdb7ab0d8ab82cd173c00ce8a9494eebf4). I’ve added a guard test to ensure that my changes don’t override the type inference logic. Not really sure if it it makes sense to have them there. As for the reader tests, I’ve tried to keep them representative while minimizing the amount of lines with recent changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
