Jefffrey commented on code in PR #9029:
URL: https://github.com/apache/arrow-rs/pull/9029#discussion_r2639017032
##########
arrow/src/util/data_gen.rs:
##########
@@ -115,11 +116,7 @@ pub fn create_random_array(
size,
primitive_null_density,
)),
- Float16 => {
- return Err(ArrowError::NotYetImplemented(
- "Float16 is not implemented".to_string(),
- ));
- }
+ Float16 => Arc::new(create_random_float16_array(size,
primitive_null_density)),
Review Comment:
Maybe we can pull in the `rand_distr` feature for `half` so we can reuse
`create_primitive_array`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
