poshul commented on PR #45234: URL: https://github.com/apache/arrow/pull/45234#issuecomment-3682889389
@wgtmac I've put together a branch based on the PR: https://github.com/poshul/arrow/tree/row_selection. The class was renamed to address the plurality problem, I've added the cstdint header and marked it as Experimental. I added unit tests (NB: these were generated with the help of an LLM). The iterator now uses `span`, intervalrange now is `start,length`, and it uses the iterators in intersect and union. Probably the biggest change was the removal of `BitmapRange`, this makes the rest of the implementation smoother, a possible path forward if we still want to take bitmaps as input it to convert them internally to intervals. As a heads up (since I couldn't find a policy in the contributors guide) some of this was assisted by Copilot, I read and individually approved the changes it suggested, but there is always the possibility that I missed some AI errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
