amoeba commented on code in PR #3837:
URL: https://github.com/apache/arrow-adbc/pull/3837#discussion_r2651723569
##########
c/driver/postgresql/validation/pyproject.toml:
##########
@@ -15,20 +15,13 @@
# specific language governing permissions and limitations
# under the License.
-[workspace]
-authors = ["Arrow ADBC Contributors"]
-channels = ["conda-forge"]
+[project]
name = "postgresql-validation"
-platforms = ["linux-64", "osx-arm64", "win-64", "linux-aarch64"]
version = "0.1.0"
+requires-python = ">=3.13"
+dependencies = [
+ "adbc-drivers-validation",
+]
-[tasks]
-validate = "pytest -vvs --junit-xml=validation-report.xml -rfEsxX tests/"
-
-[dependencies]
-python = ">=3.13.5,<3.14"
-pytest-lazy-fixtures = ">=1.3.2,<2"
-
-[pypi-dependencies]
-adbc-drivers-dev = { git = "https://github.com/adbc-drivers/dev"; }
+[tool.uv.sources]
Review Comment:
I didn't see the original PR that integrated adbc-drivers-validation into
this repo. Do you think we should pin the line below to a `rev`? Seems like we
should.
##########
c/driver/postgresql/validation/pyproject.toml:
##########
@@ -15,20 +15,13 @@
# specific language governing permissions and limitations
# under the License.
-[workspace]
-authors = ["Arrow ADBC Contributors"]
-channels = ["conda-forge"]
+[project]
name = "postgresql-validation"
-platforms = ["linux-64", "osx-arm64", "win-64", "linux-aarch64"]
version = "0.1.0"
+requires-python = ">=3.13"
+dependencies = [
+ "adbc-drivers-validation",
+]
-[tasks]
-validate = "pytest -vvs --junit-xml=validation-report.xml -rfEsxX tests/"
-
-[dependencies]
-python = ">=3.13.5,<3.14"
-pytest-lazy-fixtures = ">=1.3.2,<2"
-
-[pypi-dependencies]
-adbc-drivers-dev = { git = "https://github.com/adbc-drivers/dev"; }
+[tool.uv.sources]
adbc-drivers-validation = { git = "https://github.com/adbc-drivers/validation";
}
Review Comment:
```suggestion
adbc-drivers-validation = { git =
"https://github.com/adbc-drivers/validation";, rev =
"32a647736227f3b020776dd493153aa6eb3bff19" }
```
##########
c/driver/postgresql/validation/tests/postgresql.py:
##########
@@ -25,8 +26,8 @@ class PostgreSQLQuirks(model.DriverQuirks):
driver = "adbc_driver_postgresql"
driver_name = "ADBC PostgreSQL Driver"
vendor_name = "PostgreSQL"
- vendor_version = "180000"
- short_version = "15+"
+ vendor_version = re.compile(r"18[0-9]{4}")
Review Comment:
fancy, I didn't see you set this up so you we can cover a range of versions
with a regex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
