paleolimbot commented on code in PR #9077:
URL: https://github.com/apache/arrow-rs/pull/9077#discussion_r2656041603
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -4163,68 +4167,6 @@ mod tests {
}
}
- #[test]
- fn test_arrow_writer_explicit_schema() {
Review Comment:
The motivation for explicitly setting the Parquet schema was so that I could
write this test:
https://github.com/apache/arrow-rs/blob/843bee2c21dbe40a228c37dae7ecd876d73ee5de/parquet/tests/geospatial.rs#L281-L287
At the time there was no way to write a Parquet `Geometry` logical type
using the Arrow writer and the code path for statistics based on Arrow arrays
couldn't be tested. Several months later this was added (if the `geospatial`
feature is enabled, the appropriate extension type is translated to Geometry or
Geography on write) and we no longer need this feature for the test.
It's potentially useful as an escape hatch if the build-time features for
canonical extensions/geospatial/variant aren't fine-grained enough to satisfy
an application (e.g., perhaps allowing a runtime config option) or perhaps to
more easily create files with very specific Parquet schemas but I don't have
strong feelings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
