palday commented on code in PR #582:
URL: https://github.com/apache/arrow-julia/pull/582#discussion_r2656839168
##########
src/arraytypes/dictencoding.jl:
##########
@@ -215,6 +218,8 @@ function arrowvector(
x = x.data
len = length(x)
validity = ValidityBitmap(x)
+ # XXX This is a race condition if two workers hit this block at the same
time, then they'll create
Review Comment:
@quinnj I think there is a race condition baked into the current
architecture that can't be addressed without a very large refactoring. The
current architecture creates the locks on a worker thread if they don't already
exist, which means that threads are competing for the creation of the initial
lock. The locks should be created _before_ any tasks are spawned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
