alamb commented on code in PR #9087:
URL: https://github.com/apache/arrow-rs/pull/9087#discussion_r2657765206
##########
arrow-buffer/src/buffer/ops.rs:
##########
@@ -93,21 +103,42 @@ where
}
/// Apply a bitwise operation `op` to one input and return the result as a
Buffer.
-/// The input is treated as a bitmap, meaning that offset and length are
specified in number of bits.
-#[deprecated(
- since = "57.2.0",
- note = "use BooleanBuffer::from_bitwise_unary_op instead"
-)]
+///
+/// The input is treated as a bitmap, meaning that offset and length are
+/// specified in number of bits.
+///
+/// NOTE: The operation `op` is applied to chunks of 64 bits (u64) and any bits
+/// outside the offsets and len are set to zero out before calling `op`.
pub fn bitwise_unary_op_helper<F>(
left: &Buffer,
offset_in_bits: usize,
len_in_bits: usize,
- op: F,
+ mut op: F,
) -> Buffer
where
F: FnMut(u64) -> u64,
{
- BooleanBuffer::from_bitwise_unary_op(left, offset_in_bits, len_in_bits,
op).into_inner()
+ // reserve capacity and set length so we can get a typed view of u64 chunks
Review Comment:
This restores the behavior to what it was prior to
https://github.com/apache/arrow-rs/pull/8996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
