prmoore77 commented on code in PR #3808:
URL: https://github.com/apache/arrow-adbc/pull/3808#discussion_r2659915721
##########
go/adbc/driver/flightsql/flightsql_statement.go:
##########
@@ -540,6 +633,22 @@ func (s *statement) Bind(_ context.Context, values
arrow.RecordBatch) error {
// The driver will call Release on the record reader, but may not do this
// until Close is called.
func (s *statement) BindStream(_ context.Context, stream array.RecordReader)
error {
+ // For bulk ingest, bind to the statement
+ if s.targetTable != "" {
+ if s.bound != nil {
+ s.bound.Release()
+ s.bound = nil
+ }
+ if s.streamBind != nil {
+ s.streamBind.Release()
+ }
+ s.streamBind = stream
+ if s.streamBind != nil {
+ s.streamBind.Retain()
+ }
+ return nil
+ }
+
Review Comment:
Hi @zeroshade - I've pushed up a change with an updated error message per
your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
