jbonofre commented on code in PR #943:
URL: https://github.com/apache/arrow-java/pull/943#discussion_r2660436841
##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightMetaImpl.java:
##########
@@ -224,7 +225,8 @@ public ExecuteResult prepareAndExecute(
MetaResultSet.create(handle.connectionId, handle.id, false,
handle.signature, null);
return new ExecuteResult(Collections.singletonList(metaResultSet));
} catch (SQLTimeoutException e) {
- // So far AvaticaStatement(executeInternal) only handles NoSuchStatement
and Runtime
+ // So far AvaticaStatement(executeInternal) only handles NoSuchStatement
and
Review Comment:
nit: same here
##########
flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowFlightMetaImpl.java:
##########
@@ -79,7 +79,8 @@ static Signature newSignature(final String sql, Schema
resultSetSchema, Schema p
public void closeStatement(final StatementHandle statementHandle) {
PreparedStatement preparedStatement =
statementHandlePreparedStatementMap.remove(new
StatementHandleKey(statementHandle));
- // Testing if the prepared statement was created because the statement can
be not created until
+ // Testing if the prepared statement was created because the statement can
be
+ // not created until
Review Comment:
nit: this change is unecessary (I guess it's due to reformating)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
