kou commented on PR #925:
URL: https://github.com/apache/arrow-java/pull/925#issuecomment-3709208214
Could you try this for JNI on macOS? We need `protoc` for Gandiva JNI (not
Gandiva itself).
```diff
diff --git a/.github/workflows/rc.yml b/.github/workflows/rc.yml
index efa69533..83235d2c 100644
--- a/.github/workflows/rc.yml
+++ b/.github/workflows/rc.yml
@@ -259,11 +259,6 @@ jobs:
brew uninstall grpc || : # gRPC depends on RE2
brew uninstall [email protected] || : # gRPC 1.54 may be installed too
brew uninstall re2
- # We want to use bundled Protobuf for static linking. If
- # Homebrew's Protobuf is installed, its library file may be
- # used on test We uninstall Homebrew's Protobuf to ensure using
- # bundled Protobuf.
- brew uninstall protobuf
brew bundle --file=Brewfile
- name: Prepare ccache
diff --git a/gandiva/CMakeLists.txt b/gandiva/CMakeLists.txt
index 369829d7..d75cbe28 100644
--- a/gandiva/CMakeLists.txt
+++ b/gandiva/CMakeLists.txt
@@ -57,7 +57,6 @@ set_property(TARGET arrow_java_jni_gandiva PROPERTY
OUTPUT_NAME "gandiva_jni")
target_link_libraries(arrow_java_jni_gandiva
arrow_java_jni_gandiva_headers
jni
- protobuf::libprotobuf
Gandiva::gandiva_static)
# Localize thirdparty symbols using a linker version script. This hides them
```
Or can we remove Protobuf dependency from
https://github.com/apache/arrow-java/tree/main/gandiva ...? It will simplify
our build system...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
