rok commented on code in PR #48601:
URL: https://github.com/apache/arrow/pull/48601#discussion_r2669762546
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2317,9 +2317,18 @@ def test_strftime():
for fmt in formats:
options = pc.StrftimeOptions(fmt)
result = pc.strftime(tsa, options=options)
- # cast to the same type as result to ignore string vs
large_string
expected = pa.array(ts.strftime(fmt)).cast(result.type)
- assert result.equals(expected)
+ if sys.platform == "win32" and fmt == "%Z":
+ # TODO(GH-48743): On Windows, std::chrono returns GMT
+ # offset style (e.g. "GMT+1") instead of timezone
+ # abbreviations (e.g. "CET")
+ # https://github.com/apache/arrow/issues/48743
+ # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116110
+ for val in result:
+ assert val.as_py() is None or
val.as_py().startswith("GMT") \
+ or val.as_py() == "UTC"
Review Comment:
If we only apply the "%Z" flag then yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
