HyukjinKwon opened a new pull request, #48800: URL: https://github.com/apache/arrow/pull/48800
### Rationale for this change The XXX comment in `SharedExclusiveChecker` noted that error messages were too generic and didn't describe the actual operations involved. Shared lock: `ReadAt()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L210-L212 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L215-L217 `GetSize()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L199-L201 Exclusive lock: `Read()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L109-L111 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L114-L116 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L179-L181 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L184-L186 `Seek()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L194-L196 Tell(): https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L104-L106 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L174-L176 `Peek()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L119-L121 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L189-L191 `Close()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L94-L96 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L164-L166 `Abort()`: https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L99-L101 https://github.com/apache/arrow/blob/7be5a89ef083f38317fd94330127be5b5df648d8/cpp/src/arrow/io/concurrency.h#L169-L171 ### What changes are included in this PR? Improved three error messages in `SharedExclusiveChecker` to explicitly list the I/O operations involved: - Shared lock operations: `ReadAt`, `GetSize` - Exclusive lock operations: `Read`, `Seek`, `Tell`, `Peek`, `Close`, `Abort` ### Are these changes tested? I manually tested all of combinations. ### Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
