alamb commented on code in PR #9126:
URL: https://github.com/apache/arrow-rs/pull/9126#discussion_r2677205805
##########
arrow-ipc/src/writer.rs:
##########
@@ -3402,6 +3426,118 @@ mod tests {
assert_eq!(in_batch, out_batch);
}
+ fn test_roundtrip_list_view_of_dict_impl<OffsetSize: OffsetSizeTrait, U:
ArrowNativeType>(
Review Comment:
I verified these tests fail without the provided code fix
```
failures:
---- writer::tests::test_roundtrip_large_list_view_of_dict stdout ----
thread 'writer::tests::test_roundtrip_large_list_view_of_dict' (26537286)
panicked at arrow-ipc/src/writer.rs:2145:32:
called `Result::unwrap()` on an `Err` value: ParseError("Cannot find a
dictionary batch with dict id: 0")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- writer::tests::test_roundtrip_list_view_of_dict stdout ----
thread 'writer::tests::test_roundtrip_list_view_of_dict' (26537289) panicked
at arrow-ipc/src/writer.rs:2145:32:
called `Result::unwrap()` on an `Err` value: ParseError("Cannot find a
dictionary batch with dict id: 0")
---- writer::tests::test_roundtrip_sliced_list_view_of_dict stdout ----
thread 'writer::tests::test_roundtrip_sliced_list_view_of_dict' (26537290)
panicked at arrow-ipc/src/writer.rs:2145:32:
called `Result::unwrap()` on an `Err` value: ParseError("Cannot find a
dictionary batch with dict id: 0")
failures:
writer::tests::test_roundtrip_large_list_view_of_dict
writer::tests::test_roundtrip_list_view_of_dict
writer::tests::test_roundtrip_sliced_list_view_of_dict
test result: FAILED. 92 passed; 3 failed; 0 ignored; 0 measured; 0 filtered
out; finished in 4.73s
```
##########
arrow-schema/src/field.rs:
##########
Review Comment:
I wonder if we should (as a separate PR) add DataType::Union and
DataType::Map too 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
