alamb commented on code in PR #9066:
URL: https://github.com/apache/arrow-rs/pull/9066#discussion_r2678925523
##########
parquet/src/arrow/array_reader/cached_array_reader.rs:
##########
@@ -146,18 +152,23 @@ impl CachedArrayReader {
let array = self.inner.consume_batch()?;
+ // Capture definition and repetition levels from inner reader before
they are cleared
+ let def_levels = self.inner.get_def_levels().map(|l| l.to_vec());
Review Comment:
this copies the levels, right? It seems like we should:
1. Only copy the levels when needed (caching nested types)
2. Look into potentially being able to take the levels rather than having to
copy them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
