keirsalterego opened a new pull request, #9141: URL: https://github.com/apache/arrow-rs/pull/9141
…Array # Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #6528. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> I kept running into situations where I needed to update the null buffer of an array, usually to apply a filter or mask on top of existing nulls. Right now that forces you to drop down to unsafe APIs to rebuild the array from raw parts, which isn't ideal for such a common operation. I wanted a safe API that handles this without risking undefined behavior. By defining the operation as a union of nulls (intersecting validity), we ensure that we only ever mark valid slots as null and never accidentally unmask garbage data. This makes it safe for all array types while covering the main use case of applying validity masks. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> I implemented `with_nulls` for `PrimitiveArray`, `BooleanArray`, and `GenericByteArray`. The implementation relies on `NullBuffer::union` to safely merge the new validity mask with the existing one. I also added documentation with examples for each implementation and made sure to document that it panics if the buffer lengths don't match. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> I verified the changes locally by running the existing tests for arrow-array. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> This adds the public `with_nulls` method to the array types I mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
