HyukjinKwon opened a new pull request, #48823:
URL: https://github.com/apache/arrow/pull/48823

   ### Rationale for this change
   
   Removed a TODO from `replace_with_mask` implementation that asking why the 
replacements null count wasn't sufficient for a slice operation. When slicing 
an array, the null count from the original full array doesn't apply to the 
slice.
   
   The null count must be marked as `kUnknownNullCount` and computed lazily 
when needed.
   
   ### What changes are included in this PR?
   
   Replaced the TODO with some comments clarifying:
   - Why manual slicing is used (avoids extra allocation from 
`ArrayData::Slice()`)
   - Why `kUnknownNullCount` is necessary (original null count doesn't apply to 
slice)
   
   ### Are these changes tested?
   
   No, I did not test.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to