mohit7705 commented on code in PR #9139:
URL: https://github.com/apache/arrow-rs/pull/9139#discussion_r2681666218
##########
parquet-variant/src/variant/object.rs:
##########
@@ -390,7 +390,8 @@ impl<'m, 'v> VariantObject<'m, 'v> {
/// Returns the value of the field with the specified name, if any.
///
- /// `Ok(None)` means the field does not exist; `Err` means the search
encountered an error.
+ /// Returns `Some(Variant)` if the field exists, or `None` if the field
does not exist
+ /// or if the lookup fails safely.
Review Comment:
Good point — by “fails safely” I mean that `get` does not propagate errors
or panic.
Any internal lookup failure (e.g. during binary search or name comparison)
is handled by returning `None`. This method never returns `Err` and does not
panic; panics are only possible with the infallible indexing APIs on
unvalidated data, not with `get`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
