pitrou commented on PR #48611: URL: https://github.com/apache/arrow/pull/48611#issuecomment-3739339078
Thanks for the PR @imraniac . This is fine, but I think in general we can simplify a bit further. Two suggestions: 1) `PopCount`, `CountLeadingZeros` and `CountTrailingZeros` are now trivial wrappers around std functions, so how about we remove those wrappers and call the std functions directly? 2) `NumRequiredBits` can similarly be replaced with [`std::bit_width`](https://en.cppreference.com/w/cpp/numeric/bit_width.html), can you do this as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
