alamb commented on PR #9138:
URL: https://github.com/apache/arrow-rs/pull/9138#issuecomment-3739741636

   I am not sure we need a new crate just for the HeapSize trait in a 
downstream crate (DataFUsion)
   
   What about making a trait like this in DataFusion common:
   
   ```rust
   pub trait DFHeapSize {
   ...
   }
   ```
   
   And then providing a blanket implementation for `DFHeapSize` for everything 
that implements `HeapSize`
   
   ```rust
   impl <T: HeapSize> for DFHeapSize { 
   ...
   }
   ```
   
   That way we can use the arrow implementations, but we don't have to make a 
whole new crate etc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to