Dandandan commented on issue #78:
URL: https://github.com/apache/arrow-datafusion/issues/78#issuecomment-827528710


   Cool, thanks @alamb !
   
   I guess there are also some more opportunities for rewriting in the above 
example:
   
   `l_shipmode in (‘AIR’, ‘AIR REG’)` and `and l_shipinstruct = ‘DELIVER IN 
PERSON`  are repeated and could benefit from being simplified and then pushed 
down.
   
   `p_container in ( ‘SM CASE’, ‘SM BOX’, ‘SM PACK’, ‘SM PKG’)`, `p_container 
in (‘MED BAG’, ‘MED BOX’, ‘MED PKG’, ‘MED PACK’)` ,`p_container in ( ‘LG CASE’, 
‘LG BOX’, ‘LG PACK’, ‘LG PKG’)`
   
   could be adding a filter with all the items.
   
   `p_size between 1 and 15` , ` p_size between 1 and 10`, `p_size between 1 
and 5` could generate a filter with the least restrictive filter `p_size 
between 1 and 15`
   
   > Shall I file an issue to track this kind of rewrtite?
   Would be nice to have some tracking issue :+1: 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to