alamb commented on code in PR #9078:
URL: https://github.com/apache/arrow-rs/pull/9078#discussion_r2687496585
##########
arrow-row/src/lib.rs:
##########
@@ -1656,6 +1640,31 @@ fn row_lengths(cols: &[ArrayRef], encoders: &[Encoder])
-> LengthTracker {
tracker
}
+/// Add to [`LengthTracker`] the encoded length of each item in the
[`GenericByteArray`]
+fn push_generic_byte_array_lengths<T: ByteArrayType>(
+ tracker: &mut LengthTracker,
+ array: &GenericByteArray<T>,
+) {
+ if let Some(nulls) = array.nulls().filter(|n| n.null_count() > 0) {
+ tracker.push_variable(
+ array
+ .offsets()
+ .lengths()
+ .zip(nulls.iter())
+ .map(|(length, is_valid)| if is_valid { Some(length) } else {
None })
+ .map(variable::padded_length),
Review Comment:
I verified that `variable::encoded_len` is calling `padded_len`
https://github.com/apache/arrow-rs/blob/9213ffd035f32b657965096bf5781d1ca1d5cf67/arrow-row/src/variable.rs#L51-L50
##########
arrow-row/src/lib.rs:
##########
@@ -1656,6 +1640,31 @@ fn row_lengths(cols: &[ArrayRef], encoders: &[Encoder])
-> LengthTracker {
tracker
}
+/// Add to [`LengthTracker`] the encoded length of each item in the
[`GenericByteArray`]
+fn push_generic_byte_array_lengths<T: ByteArrayType>(
+ tracker: &mut LengthTracker,
+ array: &GenericByteArray<T>,
+) {
+ if let Some(nulls) = array.nulls().filter(|n| n.null_count() > 0) {
+ tracker.push_variable(
+ array
+ .offsets()
+ .lengths()
+ .zip(nulls.iter())
+ .map(|(length, is_valid)| if is_valid { Some(length) } else {
None })
+ .map(variable::padded_length),
+ )
+ } else {
+ tracker.push_variable(
+ array
+ .offsets()
+ .lengths()
+ .map(Some)
Review Comment:
You could potentially avoid another branch by making a version of
`padded_length` that takes `usize` instead of `Option<usize>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
