BlakeOrth commented on issue #9113:
URL: https://github.com/apache/arrow-rs/issues/9113#issuecomment-3746166956
This sounds good. I think what would have likely helped me would be the
following improvements:
- A concise, but non-trivial, example that shows the creation of a
`VariantArray` where array elements are constructed in separate methods and an
`&mut builder` is passed like the `variant-json` code
- A suggestion (and likely link) from `VariantBuilder` to prefer
`VariantArrayBuilder` (unless you _really_ need to manually construct a
`Variant`) and a short example that shows how `VariantArrayBuilder` makes
equivalent arrays to using `VariantBuilder` and `builder.append_value(variant)`
I can make a contribution with the doc updates, although I have some other
items that are higher on my priority list at the current time, so I will leave
this issue unclaimed for work until I'm confident I have the bandwidth. If it
gets scooped up by another contributor I'd be happy to review as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
