Dandandan commented on code in PR #9160:
URL: https://github.com/apache/arrow-rs/pull/9160#discussion_r2690248573
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -542,30 +542,34 @@ impl<'a, T: ByteArrayType> ArrayAccessor for &'a
GenericByteArray<T> {
impl<T: ByteArrayType> From<ArrayData> for GenericByteArray<T> {
fn from(data: ArrayData) -> Self {
+ let (data_type, len, nulls, offset, mut buffers, _child_data) =
data.into_parts();
assert_eq!(
- data.data_type(),
- &Self::DATA_TYPE,
+ data_type,
+ Self::DATA_TYPE,
"{}{}Array expects DataType::{}",
T::Offset::PREFIX,
T::PREFIX,
Self::DATA_TYPE
);
assert_eq!(
- data.buffers().len(),
+ buffers.len(),
2,
"{}{}Array data should contain 2 buffers only (offsets and
values)",
T::Offset::PREFIX,
T::PREFIX,
);
+ // buffers are offset then value, so pop in reverse
+ let value_data = buffers.pop().expect("checked above");
+ let offset_buffer = buffers.pop().expect("checked above");
+
// SAFETY:
// ArrayData is valid, and verified type above
- let value_offsets = unsafe { get_offsets(&data) };
- let value_data = data.buffers()[1].clone();
+ let value_offsets = unsafe { get_offsets_from_buffer(offset_buffer,
offset, len) };
Self {
value_offsets,
value_data,
- data_type: T::DATA_TYPE,
- nulls: data.nulls().cloned(),
+ data_type,
Review Comment:
Sometimes a lot of `Drop` can be surprisingly slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
