pitrou commented on code in PR #37400:
URL: https://github.com/apache/arrow/pull/37400#discussion_r2689174831
##########
cpp/src/parquet/properties.h:
##########
@@ -215,6 +234,15 @@ class PARQUET_EXPORT ColumnProperties {
page_index_enabled_ = page_index_enabled;
}
+ void set_bloom_filter_options(const BloomFilterOptions&
bloom_filter_options) {
+ if (bloom_filter_options.fpp >= 1.0 || bloom_filter_options.fpp <= 0.0) {
+ throw ParquetException(
+ "Bloom filter false positive probability must be in (0.0, 1.0), got
" +
Review Comment:
Oh, I had misread the conditions, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
