gruuya commented on code in PR #8700: URL: https://github.com/apache/arrow-rs/pull/8700#discussion_r2693385982
########## arrow-cast/src/parse.rs: ########## @@ -850,7 +835,9 @@ fn parse_e_notation<T: DecimalType>( } /// Parse the string format decimal value to i128/i256 format and checking the precision and scale. -/// The result value can't be out of bounds. +/// Expected behavior: +/// - the result value can't be out of bounds. +/// - when parsing a decimal with scale 0, any digits pass the decimal point will be discarded Review Comment: Good point, let me re-word this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
