alamb commented on code in PR #9185:
URL: https://github.com/apache/arrow-rs/pull/9185#discussion_r2694371259
##########
arrow-array/src/array/dictionary_array.rs:
##########
@@ -603,19 +607,10 @@ impl<T: ArrowDictionaryKeyType> From<ArrayData> for
DictionaryArray<T> {
key_data_type
);
- let values = make_array(data.child_data()[0].clone());
Review Comment:
saves a clone here of both the child data and also a `DataType::Drop`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
