HuaHuaY commented on code in PR #48865:
URL: https://github.com/apache/arrow/pull/48865#discussion_r2695142326
##########
cpp/src/arrow/util/compression_test.cc:
##########
@@ -484,37 +468,60 @@ TEST(TestCodecMisc, SpecifyCodecOptionsGZip) {
}
}
+TEST(TestCodecMisc, SpecifyCodecOptionsGZip) {
+ auto makeOption = [](int compression_level, GZipFormat format,
Review Comment:
We may not be able to use `make_optional` here unless we add a public
constructor for `GZipCodeOptions`.
##########
cpp/src/arrow/util/compression_test.cc:
##########
@@ -484,37 +468,60 @@ TEST(TestCodecMisc, SpecifyCodecOptionsGZip) {
}
}
+TEST(TestCodecMisc, SpecifyCodecOptionsGZip) {
+ auto makeOption = [](int compression_level, GZipFormat format,
Review Comment:
We may not be able to use `make_optional` here unless we add a public
constructor for `GZipCodeOptions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
