houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r621470506
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by reference or from the context
TableScan {
/// The name of the table
- table_name: String,
+ table_name: Option<String>,
Review comment:
This is needed because all the non-table scan all eventually goes into
TableScan, for example:
https://github.com/apache/arrow-datafusion/blob/245f0b8a68c5763a236aef3e727f0502188d0bfa/datafusion/src/logical_plan/builder.rs#L110-L117.
Currently we are using empty str `''` to imply scan without table names, which
makes the relation name match a little bit less readable downstream in the code
base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
