CurtHagenlocher commented on code in PR #3794:
URL: https://github.com/apache/arrow-adbc/pull/3794#discussion_r2699397380
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2HttpConnection.cs:
##########
@@ -150,6 +154,12 @@ protected override TTransport CreateTransport()
httpClient.DefaultRequestHeaders.AcceptEncoding.Add(new
StringWithQualityHeaderValue("identity"));
httpClient.DefaultRequestHeaders.ExpectContinue = false;
+ activity?.AddTag(ActivityKeys.Encrypted,
TlsOptions.IsTlsEnabled.ToString());
Review Comment:
We use object-valued tags in a lot of other places; why do the `ToString()`
here?
Same comment applies to `AddTag` calls throughout this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
