alamb commented on code in PR #604:
URL:
https://github.com/apache/arrow-rs-object-store/pull/604#discussion_r2701250812
##########
src/parse.rs:
##########
@@ -299,11 +300,35 @@ mod tests {
(ObjectStoreScheme::MicrosoftAzure, "path"),
),
(
- "az://account/container",
- (ObjectStoreScheme::MicrosoftAzure, ""),
+ "az://container/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "az://container@account/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "abfs://container/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "abfs://container@account/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "abfss://container/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "abfss://container@account/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
+ ),
+ (
+ "adl://container/path",
+ (ObjectStoreScheme::MicrosoftAzure, "path"),
),
(
- "az://account/container/path",
Review Comment:
Can we please keep this test so it is clearer what is the difference in
behavior? I am not sure what this URL will parse to now
##########
src/parse.rs:
##########
@@ -52,7 +52,7 @@ impl From<Error> for super::Error {
/// - `memory:///` -> [`InMemory`]
/// - `s3://bucket/path` -> [`AmazonS3`](crate::aws::AmazonS3) (also supports
`s3a`)
/// - `gs://bucket/path` ->
[`GoogleCloudStorage`](crate::gcp::GoogleCloudStorage)
-/// - `az://account/container/path` ->
[`MicrosoftAzure`](crate::azure::MicrosoftAzure) (also supports `adl`, `azure`,
`abfs`, `abfss`)
+/// - `[az|abfs[s]]://container[@<account>.<host>]/path` ->
[`MicrosoftAzure`](crate::azure::MicrosoftAzure)
Review Comment:
to be clear, you stopped documenting that `azure` is supported, but the code
still supports it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
