alamb commented on code in PR #9187:
URL: https://github.com/apache/arrow-rs/pull/9187#discussion_r2702399278
##########
arrow-array/src/array/fixed_size_list_array.rs:
##########
@@ -439,14 +441,13 @@ impl From<ArrayData> for FixedSizeListArray {
};
let size = value_length as usize;
- let values =
- make_array(data.child_data()[0].slice(data.offset() * size,
data.len() * size));
+ let values = make_array(child_data[0].slice(offset * size, len *
size));
Self {
- data_type: data.data_type().clone(),
+ data_type,
Review Comment:
this avoids a DataType::drop and a clone of a NullBuffer -- I don't expect
this to be a huge deal performance wise but I am trying to make all the
From<ArrayData> impls consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
