Jefffrey commented on code in PR #9207:
URL: https://github.com/apache/arrow-rs/pull/9207#discussion_r2702544673
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -826,17 +831,21 @@ where
let mut value_builder = PrimitiveBuilder::<T>::with_capacity(array.len());
+ let scale_op: ScaleOp<D> =
Review Comment:
Maybe we're better off using an approach similar to the integer to decimal
function:
https://github.com/apache/arrow-rs/blob/9c6065c451a1131393191ea828151639f031bf87/arrow-cast/src/cast/mod.rs#L384-L412
Even though it duplicates more code, it avoids the need for this type alias;
and I'm not 100% sure but maybe it inlines better 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
