Dandandan commented on code in PR #9236:
URL: https://github.com/apache/arrow-rs/pull/9236#discussion_r2712247903
##########
parquet/src/arrow/array_reader/byte_view_array.rs:
##########
@@ -330,28 +342,28 @@ impl ByteViewArrayDecoderPlain {
let to_read = len.min(self.max_remaining_values);
let buf: &[u8] = self.buf.as_ref();
- let mut read = 0;
+ let buf_len = buf.len();
+ let mut offset = self.offset;
+
output.views.reserve(to_read);
- let mut utf8_validation_begin = self.offset;
- while self.offset < self.buf.len() && read != to_read {
- if self.offset + 4 > self.buf.len() {
+ let mut utf8_validation_begin = offset;
+ for _ in 0..to_read {
Review Comment:
Somehow using `extend` here makes things slower (even though I can see in
the profile it now uses the trusted len path instead of `Vec:push`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
