lyang24 commented on PR #9093:
URL: https://github.com/apache/arrow-rs/pull/9093#issuecomment-3787205413
I dived deeper into float16. its not preallocating by design currently
with_capacity is a no-op should act the same as the original default method.
Will do some digging later on why regression happen.
```
impl ValuesBuffer for FixedLenByteArrayBuffer {
fn with_capacity(_capacity: usize) -> Self {
// byte_length is not known at trait level, so we return a default
buffer
// The decoder will pre-allocate when it knows both capacity and
byte_length
Self {
buffer: Vec::new(),
byte_length: None,
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
