jecsand838 commented on PR #9171: URL: https://github.com/apache/arrow-rs/pull/9171#issuecomment-3794181277
> Looks good to me @jecsand838 > > I have some small additional test suggestions > > * [Add additional test coverage jecsand838/arrow-rs#1](https://github.com/jecsand838/arrow-rs/pull/1) > > And some API suggestions / questions, but nothing I think is necessary before merge > > Let me know how you would like to proceed @alamb Thank you so much for the review and for the tests! I ended up merging your PR in and pushing up some changes to address the comments you left. I think your recommendations were solid and worth getting in now. Also I left some answers to your questions over the design. Let me know what you think when you get a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
