jonkeane commented on code in PR #48976: URL: https://github.com/apache/arrow/pull/48976#discussion_r2725508957
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -2867,6 +2867,15 @@ function(build_re2) fetchcontent_makeavailable(re2) + # Suppress -Wnested-anon-types warnings from RE2's use of anonymous types + # in anonymous unions (a compiler extension). + # See: https://github.com/apache/arrow/issues/48973 + if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") + if(TARGET re2) Review Comment: Ah, yes of course it already targets re2. I will fix that. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
